시간과 공간 그리고 진실의 방

Question

3

I'm trying to delete a record from the database programmatically. When I have it hardcoded like this it does delete a record from the database:

$wpdb->delete( $table_name, array( 'user_id' => 1, 'timeMin' => 10), array('%d', '%d') );

However, when I try to do it in a dynamic manner with variables, it doesn't work. I even tried casting the variables to int to make sure they are they right type.

$id = (int) wp_get_current_user()->ID;
$time = (int) $_POST['umjp_time'];

$wpdb->delete( $table_name, array( 'user_id' => $id, 'timeMin' => $time), array('%d','%d'));

Why doesn't the dynamic code using variables work and how do I fix this?

php wordpress

Share

Follow

asked May 16, 2018 at 12:27

Willem van der Veen

27.8k15 gold badges162 silver badges139 bronze badges

1

why not just use $wpdb->query($wpdb->prepare())?
– treyBake
May 16, 2018 at 12:30
1

I'll try, I thought this was the recommended way but it's not working
– Willem van der Veen
May 16, 2018 at 12:31
with Wordpress I find that their standards/best practices are to avoid haha
– treyBake
May 16, 2018 at 13:17
First: do use $wpdb->delete. It handles a lot of the prepare, etc. behind the scenes. Second: what do you get when you var_dump($id)? or var_dump($time)? The problem is almost certainly related to the values in those variables.
– random_user_name
May 16, 2018 at 13:22

Add a comment

1

why not just use $wpdb->query($wpdb->prepare())?
– treyBake
May 16, 2018 at 12:30
1

I'll try, I thought this was the recommended way but it's not working
– Willem van der Veen
May 16, 2018 at 12:31
with Wordpress I find that their standards/best practices are to avoid haha
– treyBake
May 16, 2018 at 13:17
First: do use $wpdb->delete. It handles a lot of the prepare, etc. behind the scenes. Second: what do you get when you var_dump($id)? or var_dump($time)? The problem is almost certainly related to the values in those variables.
– random_user_name
May 16, 2018 at 13:22

Answer 1

1

I tried like this and it's working for me.

global $wpdb;

$id = (int) wp_get_current_user()->ID;
$time = (int) '4';
$table_name = 'testtable';
$wpdb->show_errors(); 
$wpdb->delete( $table_name, array( 'user_id' => $id, 'timeMin' => $time), array('%d','%d'));
$wpdb->print_error();

What errors you are getting please can you explain? You can print errors by using show_errors() and print_error() methods.

Share

Follow

answered May 16, 2018 at 13:22

Ankit Panchal

1494 bronze badges

1

This is probably the most correct solution. Those using DELETE FROM will work, but that isn't how wpdb is intended to work. A little explanation would work - the critical piece being the user of array('%d') which converts the integer appropriately.
– Brian C
Jul 14, 2021 at 12:27

Add a comment

Answer 2

2

this is how I would recommend doing it:

function vendor_module_remove_dealer($data)
{
    global $wpdb;

    $sql = 'DELETE FROM `'. $wpdb->prefix .'my_table` WHERE `primary_id` = %d;';

    try {
        $wpdb->query($wpdb->prepare($sql, array($data['primary-id'])));

        return true;
    } catch (Exception $e) {
        return 'Error! '. $wpdb->last_error;
    }
}

this will prevent SQL Injection and delete your record safely, if it fails an error msg will be returned :)

Share

Follow

answered May 16, 2018 at 13:18

treyBake

6,2876 gold badges25 silver badges54 bronze badges

Add a comment

Answer 3

-2

Please use below code i think it will work.

global $wpdb;

$id = (int) wp_get_current_user()->ID;
$time = (int) $_POST['umjp_time'];

$table_name = $wpdb->prefix . 'table_name';
if (!empty($id)) 
{

  $wpdb->query($wpdb->prepare("DELETE FROM $table_name WHERE user_id IN($id)"));

}

Share

Follow

edited May 16, 2018 at 13:29

answered May 16, 2018 at 13:10

raju_odi

1,38112 silver badges27 bronze badges

1

this is open to SQL Injection :) should use the prepare method
– treyBake
May 16, 2018 at 13:17
Code-only answers are not useful. Why does this work, where OP's code doesn't? Further, this is wide open to SQL injection. Don't post answers that are open to this sort of security attack.
– random_user_name
May 16, 2018 at 13:21
sorry for missing $wpdb->prepare but now i had added.
– raju_odi
May 16, 2018 at 13:32
1

@raju_eww it's still open to SQL injection :)
– treyBake
May 16, 2018 at 13:33
1

You need to look into how to use $wpdb->prepare. It's not being used properly in your code.
– random_user_name
May 16, 2018 at 13:47

Wordpress wpdb->delete issue (0)	2022.07.04
WooCommerce Plugin Developer Handbook (0)	2021.06.11
Managing Orders And Woocommerce Status (0)	2021.06.11
Woocommerce Payment Gateway (0)	2021.06.11
Creating A Custom Plugin For WooCommerce Using WC_Integration Class in Distributed tab (0)	2021.06.11

call_user_func_array() (0)	2022.07.04
WooCommerce Plugin Developer Handbook (0)	2021.06.11
Managing Orders And Woocommerce Status (0)	2021.06.11
Woocommerce Payment Gateway (0)	2021.06.11
Creating A Custom Plugin For WooCommerce Using WC_Integration Class in Distributed tab (0)	2021.06.11

	$label = __( 'Enable Logging', 'your-textdomain-here' );
	$description = __( 'Enable the logging of errors.', 'your-textdomain-here' );

	if ( defined( 'WC_LOG_DIR' ) ) {
	$log_url = add_query_arg( 'tab', 'logs', add_query_arg( 'page', 'wc-status', admin_url( 'admin.php' ) ) );
	$log_key = 'your-plugin-slug-here-' . sanitize_file_name( wp_hash( 'your-plugin-slug-here' ) ) . '-log';
	$log_url = add_query_arg( 'log_file', $log_key, $log_url );

	$label .= ' \| ' . sprintf( __( '%1$sView Log%2$s', 'your-textdomain-here' ), '<a href="' . esc_url( $log_url ) . '">', '</a>' );
	}

	$form_fields['wc_yourpluginslug_debug'] = array(
	'title' => __( 'Debug Log', 'your-textdomain-here' ),
	'label' => $label,
	'description' => $description,
	'type' => 'checkbox',
	'default' => 'no'
	);

	<?xml version="1.0"?>
	<ruleset name="WordPress Coding Standards">
	<description>WooCommerce extension PHP_CodeSniffer ruleset.</description>

	<!– Exclude paths –>
	<exclude-pattern>tests/</exclude-pattern>
	<exclude-pattern>woo-includes/woo-functions.php</exclude-pattern>
	<exclude-pattern>woo-includes/class-wc-dependencies.php</exclude-pattern>
	<exclude-pattern>/node_modules/</exclude-pattern>
	<exclude-pattern>/vendor/</exclude-pattern>

	<!– Configs –>
	<config name="minimum_supported_wp_version" value="4.7" />
	<config name="testVersion" value="5.6-" />

	<!– Rules –>
	<rule ref="WordPress-Extra">
	<exclude name="Generic.Commenting.DocComment.SpacingAfter" />
	<exclude name="Generic.Files.LineEndings.InvalidEOLChar" />
	<exclude name="Generic.Functions.FunctionCallArgumentSpacing.SpaceBeforeComma" />
	<exclude name="PEAR.Functions.FunctionCallSignature" />
	<exclude name="Squiz.Commenting" />
	<exclude name="Squiz.PHP.DisallowSizeFunctionsInLoops.Found" />
	<exclude name="Squiz.WhiteSpace" />
	<exclude name="WordPress.Arrays" />
	<exclude name="WordPress.Files.FileName" />
	<exclude name="WordPress.NamingConventions" />
	<exclude name="WordPress.Security.ValidatedSanitizedInput.MissingUnslash" />
	<exclude name="WordPress.WP.I18n.NonSingularStringLiteralText" />
	<exclude name="WordPress.WhiteSpace" />
	</rule>

	<rule ref="WooCommerce-Core">
	<exclude name="Core.Commenting.CommentTags.AuthorTag" />
	<exclude name="WordPress.PHP.DontExtract" />
	<exclude name="Generic.Arrays.DisallowShortArraySyntax" />
	<exclude name="Generic.WhiteSpace.ScopeIndent.Incorrect" />
	</rule>

	<rule ref="PHPCompatibility">
	<exclude-pattern>tests/</exclude-pattern>
	</rule>
	</ruleset>

call_user_func_array() (0)	2022.07.04
Wordpress wpdb->delete issue (0)	2022.07.04
Managing Orders And Woocommerce Status (0)	2021.06.11
Woocommerce Payment Gateway (0)	2021.06.11
Creating A Custom Plugin For WooCommerce Using WC_Integration Class in Distributed tab (0)	2021.06.11

Awaiting payment – stock is reduced, but you need to confirm payment	Usually seen with payment methods when you need to manually confirm, such as BACS (bank transfer) or cheque. You’ll also see this when the gateway is set to authorize instead of capture a charge: the shop owner will need to manually switch the status to processing.
Order received (unpaid).	Most gateways will report back and set the order status to Processing (payment successful) or Failed (payment unsuccessful). If the shop never receives either signal, it keeps the status on Pending. This tends to be a misconfiguration of payment notification URLs or a plugin conflict.
Payment received and stock has been reduced- the order is awaiting fulfillment. All product orders require processing, except those with only products that are both digital and downloadable.	If the payment has been successful and the order does not contain Digital or Downloadable products, the order will be set to Processing. This is the shop owner or warehouse’s cue to ship the order and manually mark it as completed.
Order fulfilled and complete – requires no further action	These generally aren’t interesting because everything has gone correctly.
Payment failed or was declined (unpaid).	The order can be manually canceled, but this status can come up if the payment window has expired. It can happen for a few reasons: order was abandoned before payment was completeThe hold stock window expired without a response Same reasons as Pending
Customer must complete requirements for SCA.	It can occur when: a new customer makes a purchase an existing subscription renews

시간과 공간 그리고 진실의 방

WEB/WP(WordPress)

call_user_func_array()

'WEB > WP(WordPress)' 카테고리의 다른 글

Wordpress wpdb->delete issue

3 Answers

'WEB > WP(WordPress)' 카테고리의 다른 글

WooCommerce Plugin Developer Handbook

Check if WooCommerce is active

Main file naming

Text domains

Localization

Follow WordPress PHP Guidelines

Custom Database Tables & Data Storage

Prevent Data Leaks

Readme

Plugin Author Name

Declaring required and supported WooCommerce version

Plugin URI

Woo Plugin Header For Updates

Make it Extensible

Remove Unused Code

Comment

Avoid God Objects

Test Your Code with WP_DEBUG

Separate Business Logic & Presentation Logic

Use Transients to Store Offsite Information

Logging Data

Error codes

error_success

error_pbs_prepare_apache

error_pbs_prepare_mysql

error_pbs_prepare_wp

error_pbs_prepare_wc

error_pbs_prepare_dependencies

error_pbs_test_malware_scanning

error_pbs_test_extracting

error_pbs_test_phpcs

error_pbs_test_installing

error_pbs_test_activating

error_pbs_test_deactivating

error_pbs_test_host_plan_installing

error_pbs_test_host_plan_activating

error_pbs_test_host_plan_deactivating

error_pbs_missing_theme_info_file

error_pbs_incomplete_theme_info

error_pbs_incomplete_theme_header

error_pbs_incomplete_plugin_header

error_pbs_invalid_woo_header

error_pbs_invalid_id

error_pbs_invalid_hash

error_pbs_missing_main_file

error_pbs_missing_changelog_file

error_pbs_product_version_mismatch

error_pbs_invalid_changelog_format

'WEB > WP(WordPress)' 카테고리의 다른 글

Managing Orders And Woocommerce Status

Order Statuses

Visual Diagram to Illustrate Order Statuses

Order Statuses and Payment Gateways

Order Statuses and Emails

Viewing and Managing Multiple Orders

Orders Overview

Filter and Arrange Orders

Searching and Finding Orders

Previewing Orders

Order Statuses in the Overview

Order Actions

Viewing and Editing a Single Order

Order Details

Order Items and Totals

Custom Fields

Order Notes

Manually Adding an Order

Paying for an Order

Removing Personal Data

Multi-Site Orders

Troubleshooting

Understanding Order Statuses in Relation to Payment Gateways

Questions